Skip to content

Add arguments in correct order when building Object #248

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 23, 2019

Conversation

almyy
Copy link
Contributor

@almyy almyy commented Mar 9, 2019

This commit fixes #217

@almyy almyy changed the title Add arguments in correct order when creating building Object Add arguments in correct order when building Object Mar 12, 2019
@karl-run
Copy link

Anything holding this back @oliemansm? Would love to see this merged. 😸

@oliemansm
Copy link
Member

@karl-run Just finding the time :)

@oliemansm oliemansm merged commit 0802f3e into graphql-java-kickstart:master Mar 23, 2019
@oliemansm
Copy link
Member

@almyy Thanks for the contribution!

@karl-run
Copy link

karl-run commented Apr 5, 2019

@oliemansm Thanks for merging. I know OSS can be a bit difficult at times. :)

Do you have any time-frame on when this will be released?

@oliemansm oliemansm added this to the 5.4.2 milestone Apr 6, 2019
@oliemansm
Copy link
Member

@karl-run Will release in a minute, so should be available on central soon.

@viktor-zharina-qs
Copy link

Could you check it in case when both input parameters is not required.
Example

interface ITarget {
    id: UUID!
    field(p1="DEFAULT", p2:[String]=["ALL"]): [SomeType!]!
}

type One implements ITarget {
    id: UUID!,
    field(p1="DEFAULT", p2:[String]=["ALL"]): [SomeType!]!
}

Got the same error as described in #217

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug - Unable to create interfaces with fields with multiple arguments
4 participants